-
Notifications
You must be signed in to change notification settings - Fork 1.2k
apitypes: openapi spec #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apitypes: openapi spec #2308
Conversation
e22f298 to
38723ef
Compare
1c01176 to
8710b4d
Compare
|
Crozzy and I went through the endpoints this afternoon and made sure they were all in the OpenAPI document. I'll take another pass on the |
051419c to
c69e119
Compare
c69e119 to
d52b9c6
Compare
|
Okay, I think this is ready to go. This adds a bunch of documentation and tooling, but only makes a few code changes. Those will come in a later PR. |
af40d0d to
6110f81
Compare
crozzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been through this and it LGTM, one ask I have is some doc to tell the developer how to update the openapi spec and perhaps how the different generation scripts interact.
|
Will do. |
6110f81 to
1644e2c
Compare
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Creating this file is now handled by the same script that generates the OpenAPI doc, so being able to build it independently and needing to check it for drift don't make a ton of sense. Signed-off-by: Hank Donnay <[email protected]>
1644e2c to
5891f64
Compare
crozzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the guide, it worked with me after I updated the npm version
|
/fast-forward |
This series (split from #2266) adds JSON Schema documents for all the types exposed in the HTTP API and adds a way to generate the OpenAPI specification from those, a
jqscript, and some other loose files.TODO
"description"members for the JSON Schema documents."description"members for the OpenAPI document../Documentation/reference/api.md) is at least as-useful as it was.Coming later in series: